Working Fix For Pattern Lab Lineages When Using Custom Twig Namespaces#21
Closed
Working Fix For Pattern Lab Lineages When Using Custom Twig Namespaces#21
Conversation
Collaborator
Author
|
Collaborator
Author
|
Closing out - new PR opened pattern-lab#127 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses original issue opened here: EvanLovely/plugin-twig-namespaces#4
Without this workaround when using the Pattern Lab Twig Namespaces plugin using a path / directory other than the one PL would normally assign (ex. one single
@mylibraryalias for any pattern to be included by) the original Lineage fix stops working entirely and you get dozens and dozens and dozens of warnings saying you're PL includes / embeds / extends aren't referencing arealpattern.CC @evanmwillhite @jesconstantine @bradfrost